Skip to content

Replace deprecated withState with useState #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaymcp wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Replace deprecated withState with useState #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions private/src/block/components/tag.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import classnames from 'classnames';
import PropTypes from 'prop-types';

const { Button, Dashicon, Popover } = wp.components;
const { withInstanceId, withState } = wp.compose;
const { Fragment } = wp.element;
const { withInstanceId } = wp.compose;
const { Fragment, useState } = wp.element;
const { __, sprintf } = wp.i18n;

/**
Expand All @@ -19,14 +19,14 @@ const { __, sprintf } = wp.i18n;
const Tag = ({
id,
instanceId,
isVisible,
label,
popoverContents,
remove,
screenReaderLabel,
setState,
className,
}) => {
const [isVisible, setIsVisible] = useState(false);

if (!label) {
// A null label probably means something went wrong
// @todo Maybe this should be a loading indicator?
Expand All @@ -52,7 +52,7 @@ const Tag = ({
<Button
className="woocommerce-tag__text"
id={labelId}
onClick={() => setState(() => ({ isVisible: true }))}
onClick={() => setIsVisible(true)}
isToggled={isVisible}
>
{labelTextNode}
Expand All @@ -63,7 +63,7 @@ const Tag = ({
</span>
)}
{popoverContents && isVisible && (
<Popover onClose={() => setState(() => ({ isVisible: false }))}>{popoverContents}</Popover>
<Popover onClose={() => setIsVisible(false)}>{popoverContents}</Popover>
)}
{remove && (
<Button
Expand Down Expand Up @@ -102,4 +102,4 @@ Tag.propTypes = {
screenReaderLabel: PropTypes.string,
};

export default withState({ isVisible: false })(withInstanceId(Tag));
export default withInstanceId(Tag);