Feature/sar-699 user profile interface #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 15, 2022 18:12
added 3 commits
January 6, 2023 12:51
m-ox
suggested changes
Jan 20, 2023
Contributor
m-ox
left a comment
m-ox
left a comment
There was a problem hiding this comment.
I'm personally excited about it. Just needs merge conflicts and basic console log clean up done. Has thorough error handling and I'm happy to finally see what the user object is looking like.
| redirect_uri: googleOAuthRedirectUrl, | ||
| grant_type: 'authorization_code', | ||
| }; | ||
| console.log(values); |
Collaborator
There was a problem hiding this comment.
And below this, comment clean up
anthem123
reviewed
Jan 27, 2023
| { | ||
| "_id": "aab", | ||
| "aab": { | ||
| "measureClassification": "Classic", |
Collaborator
There was a problem hiding this comment.
Is this going to be used anywhere? And all the values appear to be the same. Just curious what this is for.
anthem123
reviewed
Jan 27, 2023
| }; | ||
|
|
||
| const addUser = async (req, res, next) => { | ||
| const { |
Collaborator
There was a problem hiding this comment.
About 50% of this file is copying the same 12 fields around 3 different places. I bet a function can handle this to reduce duplicate code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Tickets
Other Repos' PR(s) Intended to Work With This PR
How Things Worked (or Didn't) Before This PR
How Things Work Now (And How to Test)
-User Profile is editable.
-User is allowed to change only their settings. (for certain selections)
-User unable to change company settings.
-Admin route added for adding new user, and also finding members.
Readiness