Print type name when panicking due to violating aliasing laws#239
Merged
Imberflur merged 3 commits intoamethyst:masterfrom Feb 28, 2025
Merged
Print type name when panicking due to violating aliasing laws#239Imberflur merged 3 commits intoamethyst:masterfrom
Imberflur merged 3 commits intoamethyst:masterfrom
Conversation
Contributor
|
Hi, was this closed from inactivity? I just fixed the unrelated issues causing the CI to fail. |
Contributor
Author
|
No, I'm no longer working at the company that this work was for. But I can re-open if you want to take the PR? |
Contributor
Looks like a nice improvement to me and didn't have any performance impact when I tested it so I think merging it would be nice. |
richard-uk1
force-pushed
the
type_name
branch
from
eb17ca3 to
564b78e
Compare
richard-uk1
force-pushed
the
type_name
branch
from
564b78e to
99ab04b
Compare
Contributor
Author
|
CI is green |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have a lot of storages in a big project, and especially when backtraces are not available (e.g. web) it can be difficult to know which storage is breaking the borrow rules (mut + immut borrow or 2+ mut borrows). This patch adds the type name to the panic message.