This repository was archived by the owner on Nov 7, 2019. It is now read-only.
Open
Conversation
`make codegen` now builds a new version of the codegen tool before trying to run it. The command also now looks to a binary in the code-generation directory instead of requiring installation. This also adds a `go fmt` command to the code generation to remove formatting diffs from the bindata generation stage.
Contributor
|
We include the changes from #136 in this PR |
Contributor
Author
|
@christopherhein Can you help me understand why this was closed? |
Contributor
|
Sorry about thank @joerocklin thanks for calling that out. I was mistaken that this was the same as #136 but at second look you are right. Any chance you can update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #62
Description of changes: This removes the need to separately install the codegen component.
make build-codegenormake rebuildwill handle preparing things.make aws-codegen(and callers) will then use the local binary.It will also format the bindata code if it changes to preserve formatting.
Installation of go-bindata is still required. It would be nice to run this from a vendored source for consistency, maybe that can be a future effort.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.