This repository was archived by the owner on Nov 7, 2019. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #128
Description of changes: Many of the changes contained here are from updating dep and running the codegen process. It also builds on #127.
This adds a small helper to fetch the contents of the CF Template from the URL and perform template substitution. I consider this a partial solution as it stands since it requires the parameters to be defined in the CF Template even if they are only used in the golang template process. I have a fix for #126 which does not require any unusual workarounds on the CloudFormation side.
If master is updated to reflect the dep updates and base codegen I can rebase this to make it more clear what is changing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.