Skip to content

Implement RFC 73: Stricter connections.#1637

Merged
whitequark merged 2 commits intoamaranth-lang:mainfrom
zyp:rfc_73
Jan 21, 2026
Merged

Implement RFC 73: Stricter connections.#1637
whitequark merged 2 commits intoamaranth-lang:mainfrom
zyp:rfc_73

Conversation

@zyp
Copy link
Contributor

@zyp zyp commented Oct 18, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.28%. Comparing base (f6d02d2) to head (88f0401).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
amaranth/lib/wiring.py 75.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
- Coverage   91.29%   91.28%   -0.02%     
==========================================
  Files          44       44              
  Lines       11493    11517      +24     
  Branches     2238     2242       +4     
==========================================
+ Hits        10493    10513      +20     
- Misses        837      842       +5     
+ Partials      163      162       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs at the very least:

  • Tests for changes in lib.data and lib.enum
  • Changelog update

@zyp zyp marked this pull request as ready for review January 21, 2026 12:02
@zyp zyp requested a review from whitequark January 21, 2026 12:08
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@whitequark whitequark added this pull request to the merge queue Jan 21, 2026
Merged via the queue into amaranth-lang:main with commit 738a9da Jan 21, 2026
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants