hdl._ir: chain Fragment.origins with preexisting#1593
Merged
whitequark merged 1 commit intoamaranth-lang:mainfrom May 12, 2025
Merged
hdl._ir: chain Fragment.origins with preexisting#1593whitequark merged 1 commit intoamaranth-lang:mainfrom
whitequark merged 1 commit intoamaranth-lang:mainfrom
Conversation
By chaining, `Fragment.origins` gets tracked through `FragmentTransformer`s
Merged
via the queue into
amaranth-lang:main
with commit May 12, 2025
d805f96
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
Fragment.originsfrom being overwritten if duringFragment.getaFragmentis encountered that already has aFragment.originsfield toappending to the preexisting
originstuple. This case is interesting for anything using aFragmentTransformer. With this change,no longer asserts, like it does currently.
Some before after examples:
Before:
After:
Furthermore, with this change, the duplicate fragment check performed by
Fragment.prepare()now also works if the duplicate is behind something that uses a fragment transformer, for examplepreviously did not raise any exception, but now (correctly) raises: