Protocol improvements, docs compatibility - #8
Open
xRookieFight wants to merge 13 commits into
Open
Conversation
xRookieFight
marked this pull request as ready for review
August 12, 2026 15:10
Contributor
Author
|
Ready for review @altayofficial/dev-team |
|
I don't quite understand—why are you throwing a |
Contributor
Those should be InvalidArgumentException |
Contributor
Author
|
Yeah, it was out of my mind |
Merged
Contributor
Author
|
Will merge it when I wire it to the main repo too |
Contributor
Author
|
Will be merged after 1.26.50 release, we should not break the wire for now |
nicholass003
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved protocol by being compatible to the official docs
It has some internal API breaks, if you're reviewing it please do not merge it until I do.