Open
Conversation
This reverts commit a54e56b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a real solution, just some random stuff Claude created and I don't understand (except the Ruby part, I understand it's less that good and not an idiomatic approach), don't merge!
Ruby gem added in #2022 doesn't include the native library in the way Python packages do. Regular pre-compiled gems aren't similar to wheels, but in case of a ffi shared library (not some native Ruby extension) they should be pretty close (I guess native libs can be reused). Still, I don't understand you build process (Where are packages other that Python are built, for example? Don't Java/Android packages have native libraries pre-compiled?) and am not familiar with
travis.@nshmyrev If you don't have time to assist, please release a new Python package version to PyPi, so I'll be able to test new features in Ruby and will update install instructions to tell users to copy the native library from the Python package (or even do it automatically)