Skip to content

llvm build fix#7

Merged
allcreater merged 4 commits intomasterfrom
feature/build_update_v2
Apr 13, 2026
Merged

llvm build fix#7
allcreater merged 4 commits intomasterfrom
feature/build_update_v2

Conversation

@allcreater
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 13, 2026 13:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s CMake configuration and CI setup to better support C++23 builds (including module/std import experimentation) across platforms.

Changes:

  • Centralized common CMake preset settings (Ninja generator + build/install directories) into the shared base preset.
  • Tightened C++ standard enforcement and updated the CMake version gating for CMAKE_EXPERIMENTAL_CXX_IMPORT_STD.
  • Adjusted Ubuntu CI compiler setup toward LLVM/Clang 19 and attempted to force clang/clang++ to point to version 19.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
CMakePresets.json Moves generator/build/install directory settings into the shared base preset for reuse.
CMakeLists.txt Enforces C++23 more strictly and updates experimental import std GUID selection by CMake version.
.github/workflows/cmake-multi-platform.yml Updates Ubuntu compiler setup to LLVM/Clang 19 and adds update-alternatives steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +66 to +67
sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-19 100
sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-19 100
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new update-alternatives calls assume /usr/bin/clang-19 and /usr/bin/clang++-19 exist on the runner. If aminya/setup-cpp installs LLVM into a different prefix (common on GitHub runners), this step will fail and break CI. Consider either (a) installing clang-19 via apt-get explicitly before calling update-alternatives, (b) guarding these commands with an existence check, or (c) setting CC/CXX to the exact compiler path provided by the setup action instead of rewriting system alternatives.

Suggested change
sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-19 100
sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-19 100
if [ -x /usr/bin/clang-19 ]; then
sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-19 100
fi
if [ -x /usr/bin/clang++-19 ]; then
sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-19 100
fi

Copilot uses AI. Check for mistakes.
Comment thread CMakePresets.json
@allcreater allcreater changed the title Feature/build update v2 llvm build fix Apr 13, 2026
@allcreater allcreater merged commit b96ded3 into master Apr 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants