Skip to content

fix(ci): break long compileall line to pass yamllint#501

Merged
alirezarezvani merged 1 commit intodevfrom
claude/audit-pr-498-workflow-Pa5Ku
Apr 8, 2026
Merged

fix(ci): break long compileall line to pass yamllint#501
alirezarezvani merged 1 commit intodevfrom
claude/audit-pr-498-workflow-Pa5Ku

Conversation

@alirezarezvani
Copy link
Copy Markdown
Owner

Summary\n\n- Splits the python -m compileall command in ci-quality-gate.yml across multiple lines to stay under the 160-character yamllint limit (was 166 chars)\n- This was a pre-existing issue surfaced after the fork PR checkout fix in #499\n\n## Test plan\n\n- [ ] Verify yamllint passes on all workflow files\n- [ ] Verify python -m compileall still compiles the same directories\n\nhttps://claude.ai/code/session_01X1RKFAkEwxgg6gQvJG1KCa

@claude
Copy link
Copy Markdown

claude bot commented Apr 8, 2026

PR Review: fix(ci): break long compileall line to pass yamllint

Summary: Minimal, focused fix for a yamllint line-length violation. No functional changes.

Code Quality ✅

The change is correct and clean:

  • All original directories are preserved in the same order
  • Bash \ line continuation syntax is valid inside a YAML run: | block
  • Each resulting line stays well under the 160-char limit

Potential Issues — None

  • Directory list is identical to the original (verified by diff inspection)
  • No accidental omissions or additions
  • Grouping across lines is cosmetically arbitrary but functionally irrelevant

Suggestions (non-blocking)

Consider keeping the line continuation grouping consistent with the repo's domain structure — e.g. one line per logical domain cluster. The current grouping (marketing+product+c-level / engineering+ra+eng / biz+fin+pm+scripts) works fine but is slightly arbitrary. Not a blocker.

Verdict

Approve. This is a clean, minimal CI fix with no risk of regression. The test plan items (yamllint pass + same directories compiled) are straightforward to verify in CI.

@alirezarezvani alirezarezvani merged commit 9332c07 into dev Apr 8, 2026
3 checks passed
@alirezarezvani alirezarezvani deleted the claude/audit-pr-498-workflow-Pa5Ku branch April 8, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants