Skip to content

Guard empty PR reconciliation results#458

Open
nicobistolfi wants to merge 3 commits intomainfrom
vigilante/issue-456-fix-false-no-pull-request-was-created-loop-when-a-pr-already-exists-for-the-issue-branch
Open

Guard empty PR reconciliation results#458
nicobistolfi wants to merge 3 commits intomainfrom
vigilante/issue-456-fix-false-no-pull-request-was-created-loop-when-a-pr-already-exists-for-the-issue-branch

Conversation

@nicobistolfi
Copy link
Copy Markdown
Collaborator

Summary

  • guard the post-run and resume PR reconciliation paths when branch lookup returns no PR
  • keep true commits_without_pr sessions incomplete without panicking
  • add regression tests for empty lookup results in both runner and app reconciliation flows

Validation

  • go test ./internal/runner ./internal/app
  • go vet ./internal/runner ./internal/app
  • go test ./...

Closes #456

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 16, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
vigilante ace6024 Commit Preview URL

Branch Preview URL
Apr 16 2026, 10:18 PM

@nicobistolfi nicobistolfi force-pushed the vigilante/issue-456-fix-false-no-pull-request-was-created-loop-when-a-pr-already-exists-for-the-issue-branch branch from c027524 to ace6024 Compare April 16, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix false 'no pull request was created' loop when a PR already exists for the issue branch

1 participant