bugfix : prevent creation of duplicate users#58
Open
medaminefracso wants to merge 2 commits intoali-bouali:mainfrom
Open
bugfix : prevent creation of duplicate users#58medaminefracso wants to merge 2 commits intoali-bouali:mainfrom
medaminefracso wants to merge 2 commits intoali-bouali:mainfrom
Conversation
medaminefracso
changed the title
| // Check if the given user exists in database | ||
| boolean isPresent = repository.findByEmail(request.getEmail()).isPresent(); | ||
| var user = isPresent | ||
| ? repository.findByEmail(request.getEmail()).get() |
There was a problem hiding this comment.
You are fetching the same data twice from DB?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's say, we'll use the following JSON as a body to the registration POST request :
If you send multiple POST requests with the same JSON body, a user is created each time in the database, thus this leads to duplicate users in the database.
To fix this issue, in AuthenticationService, I added a boolean that checks if the user exists in the database. If it's true just extract the user, otherwise create it & save it to database.