Conversation
nekitbr
left a comment
There was a problem hiding this comment.
The previous solution was bad and didn't user the antMatcher from the middleware RequestMatcher. This needs to be done because the String[] of routes is meant to be used there, thus we should abide by it's rules.
src/main/java/com/alibou/security/config/JwtAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
|
please if you could check this out @ali-bouali :) |
|
Hi @nekitbr , Also, I want to mention that your Github username will be on the video. I hope this is okay with you. Otherwise, please let me know so I can sensor it in the video |
Thanks a lot for appreciating my contribution. As for including my GitHub username in the video, I'm totally cool with it. Actually, I appreciate the recognition and exposure :)) Can't wait to see the video! |
This PR intends to refactor the way whitelisted routes are unprotected.
After the merge, we can declare all whitelisted routes in one place and the filter will behave accordingly.
These issues were created before the original solution on the commit dfee1e5
closes #8
closes #12
closes #20