Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements reproducible builds for ksh (Korn Shell) variants by adding comprehensive build determinism measures and patching source-level non-determinism in floating-point padding.
Changes:
- Added extensive reproducible build flags and environment configuration to the ksh build process including SOURCE_DATE_EPOCH, deterministic compiler flags, and ar/ranlib wrapper scripts
- Introduced source-level patches to zero-initialize long double padding bytes before use to eliminate non-deterministic memory contents in build artifacts
- Added
patchutility dependency for 93uplusm fork variants that now require patch application
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| variants/ksh.sh | Implements reproducible build system with tar normalization, timestamp control, compiler flags, ar/ranlib wrappers, meson LTO disable, and binary stripping |
| patches/ksh/shvrChistory-b_2016-01-10/002-long-double-nan-pad.diff | Patches ksh source to memset long double variables before use to ensure deterministic padding bytes |
| patches/ksh/shvrChistory-b_2012-08-01/002-long-double-nan-pad.diff | Patches ksh source to memset long double variables before use to ensure deterministic padding bytes |
| patches/ksh/shvrChistory-b_2011-03-10/002-long-double-nan-pad.diff | Patches ksh source to memset long double variables before use to ensure deterministic padding bytes |
| patches/ksh/shvrChistory-b_2010-10-26/002-long-double-nan-pad.diff | Patches ksh source to memset long double variables before use to ensure deterministic padding bytes |
| patches/ksh/shvrChistory-b_2010-06-21/002-long-double-nan-pad.diff | Patches ksh source to memset long double variables before use to ensure deterministic padding bytes |
| patches/ksh/shvrChistory-b_2008-11-04/002-long-double-nan-pad.diff | Patches ksh source to memset long double variables before use to ensure deterministic padding bytes |
| patches/ksh/shvrChistory-b_2008-06-08/002-long-double-nan-pad.diff | Patches ksh source to memset long double variables before use to ensure deterministic padding bytes |
| patches/ksh/shvrChistory-b_2008-02-02/002-long-double-nan-pad.diff | Patches ksh source to memset long double variables before use to ensure deterministic padding bytes |
| patches/ksh/shvrA93uplusm-v1.0.2/002-long-double-nan-pad.diff | Patches ksh source to memset long double variables before use to ensure deterministic padding bytes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.