Skip to content

Housekeeping: checksums, workflow permissions, README.md#31

Merged
alganet merged 1 commit intomainfrom
housekeeping
Nov 24, 2025
Merged

Housekeeping: checksums, workflow permissions, README.md#31
alganet merged 1 commit intomainfrom
housekeeping

Conversation

@alganet
Copy link
Owner

@alganet alganet commented Nov 24, 2025

  • Add a test to prevent us from writing workflows with no explicit permissions.
  • Add explicit permissions to all workflows.
  • Move checksums/ to checksum/sources/ in preparation for true artifact checksums and reproducibility.
  • README.md updates.

@alganet alganet force-pushed the housekeeping branch 3 times, most recently from 9fa8651 to d490877 Compare November 24, 2025 16:04
@alganet alganet requested a review from Copilot November 24, 2025 16:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements security and organizational improvements by adding explicit permissions to workflows, reorganizing checksum storage, and updating documentation. The changes enforce workflow security best practices while preparing the project structure for future artifact checksums and reproducibility features.

Key changes:

  • Adds a verification job to prevent workflows from being created without explicit permissions
  • Moves checksums from checksums/<shell>/ to checksums/sources/<shell>/ directory structure
  • Relocates checksum documentation from main README.md to dedicated checksums/README.md

Reviewed changes

Copilot reviewed 6 out of 566 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
checksums/README.md New dedicated documentation for checksum verification process
README.md Removes checksum documentation section (moved to checksums/README.md)
.github/workflows/test-verification.yml Adds permissions and new job to verify all workflows have explicit permissions
.github/workflows/docker-test.yml Adds explicit permissions declaration
.github/workflows/docker-latest.yml Adds explicit permissions declaration
.github/workflows/docker-all.yml Adds explicit permissions declaration

 - Add a test to prevent us from writing workflows with no
   explicit permissions.
 - Add explicit permissions to all workflows.
 - Move `checksums/` to `checksum/sources/` in preparation
   for true artifact checksums and reproducibility.
 - README.md updates.
@alganet alganet marked this pull request as ready for review November 24, 2025 21:00
@alganet alganet merged commit b3ddd20 into main Nov 24, 2025
6 checks passed
@alganet alganet deleted the housekeeping branch November 24, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant