Housekeeping: checksums, workflow permissions, README.md#31
Merged
Conversation
9fa8651 to
d490877
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements security and organizational improvements by adding explicit permissions to workflows, reorganizing checksum storage, and updating documentation. The changes enforce workflow security best practices while preparing the project structure for future artifact checksums and reproducibility features.
Key changes:
- Adds a verification job to prevent workflows from being created without explicit permissions
- Moves checksums from
checksums/<shell>/tochecksums/sources/<shell>/directory structure - Relocates checksum documentation from main README.md to dedicated checksums/README.md
Reviewed changes
Copilot reviewed 6 out of 566 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| checksums/README.md | New dedicated documentation for checksum verification process |
| README.md | Removes checksum documentation section (moved to checksums/README.md) |
| .github/workflows/test-verification.yml | Adds permissions and new job to verify all workflows have explicit permissions |
| .github/workflows/docker-test.yml | Adds explicit permissions declaration |
| .github/workflows/docker-latest.yml | Adds explicit permissions declaration |
| .github/workflows/docker-all.yml | Adds explicit permissions declaration |
- Add a test to prevent us from writing workflows with no explicit permissions. - Add explicit permissions to all workflows. - Move `checksums/` to `checksum/sources/` in preparation for true artifact checksums and reproducibility. - README.md updates.
d490877 to
8c1bd10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checksums/tochecksum/sources/in preparation for true artifact checksums and reproducibility.