feat: auto-detect test executables via CMake Tools#37
Open
haikion wants to merge 1 commit intoalfaix:mainfrom
Open
feat: auto-detect test executables via CMake Tools#37haikion wants to merge 1 commit intoalfaix:mainfrom
haikion wants to merge 1 commit intoalfaix:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automatic detection of Google Test executables via CMake Tools. This is largely based on the discussions in issue #12. The submitted patch sort of worked but required a few tweaks. Permission to use the patch was granted, and credit will be given to the original authors in the form of a code comment. I also added a couple of tests. Feature has some imperfections, which I consider out of scope.
Working
Known issues
I omitted implementation for directory-based discovery, as neotest-gtest seems to assume that a directory maps to a single test executable, which is not always the case. cmake-tools expects the current working directory to be in the project root, so fixing such issues would quickly snowball.
closes #12