Added channel configuration and names#306
Open
aschempp wants to merge 2 commits intoalexryd:masterfrom
Open
Conversation
|
@aschempp thanks for this pull request, it helps a lot with my Shellies 2.5. |
|
Thanks for this PR. Is the project no longer supported at all? The request has been open for so long now. |
|
This is a real issue for me too. Would be good to get this sorted. Unfortunate that the developer seems absent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds per-channel configuration, currently supporting a channel name and to exclude specific channels. In my case, I can name or exclude each channel of a RGBW2 in white-mode as well as channels of Shelly 2.5
The changes now also fetch the channel's name from a device if available and uses it instead of the device name.
This should fix the following issues: #277 #261 #236 #219 #116 #198