fix: 🐛 consider initial rangeStartDay value in range selection#875
Open
moazelsawaf wants to merge 3 commits intoaleksanderwozniak:masterfrom
Open
fix: 🐛 consider initial rangeStartDay value in range selection#875moazelsawaf wants to merge 3 commits intoaleksanderwozniak:masterfrom
rangeStartDay value in range selection#875moazelsawaf wants to merge 3 commits intoaleksanderwozniak:masterfrom
Conversation
Author
|
@aleksanderwozniak Could you please review this PR? 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there 👋🏻,
I just wanted to thank you for this great package! It's been really helpful for my Flutter projects 💪🏻💙
While using it in one of my apps, I found a small bug. It wasn't considering the starting day I set in
rangeStartDayparameter in Range Selection. So, when I tapped on a day, it started selecting from the Start Day instead of just the End Day like it should 🐛In this PR, I fixed the bug, tested it well, and now it works perfectly without affecting another functionality in the package 🛠️👍🏻
I hope you find it helpful 🙏🏻
Thanks again for your hard work in the Flutter community 💙 🙏🏻