Open
Conversation
If a nil pointer to a type T that implements IsZero() with a value receiver is passed to repr, it will panic due to the nil pointer being automatically dereferenced in the IsZero() method invocation.
Check if IsZero() is implemented with a value receiver, and avoid calling it if the value is a nil pointer because this will panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the automatic dereferencing that Go does when calling a method implemented with a value receiver on a pointer type, calling
IsZero()on a nil pointer can panic.This PR adds a test for this issue and a check to avoid it.
Closes: #37