Open
Conversation
Owner
|
repr is supposed to detect recursive loops, we should fix that rather than adding extra functionality to work around that |
Owner
|
Is it possible to provide a minimal working example for a case where the recursion detection fails? |
Owner
|
There's an existing test for this exact scenario of parent references, so there must be something else going on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This masks certain struct keys.
The use case was to print a
yang.Entryfrom https://github.com/openconfig/goyangEach yang.Entry / yang.Node etc can have a parent which seems to recursively cause repr.Print to go into a loop
This now works with
Open to change the name MaskKeys / HideKeys etc.
Could also use ... as you currently use in the seen logic