adding functionality to provide explicit validation dataset #48
Open
llevitis wants to merge 1 commit intoalawryaguila:masterfrom
Open
adding functionality to provide explicit validation dataset #48llevitis wants to merge 1 commit intoalawryaguila:masterfrom
llevitis wants to merge 1 commit intoalawryaguila:masterfrom
Conversation
… corresponding to train/val status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding functionality to provide a validation dataset directly instead of splitting training data in scenarios where data leakage needs to be avoided between training and validation. I've made the following changes:
fitfunction inbase_model.pyhas been updated to accept an optionalsplit_labelsargument that is a list comprised oftrainandvalentries to be used for splitting the input*data.dataloaders.pyto split the input data either using thesplit_labelsor by splitting data directly into 90% for training and 10% for validation