ClusterSingletonManager lease release fault not handled on leaving#8065
Open
MattKotsenas wants to merge 1 commit intoakkadotnet:devfrom
Open
ClusterSingletonManager lease release fault not handled on leaving#8065MattKotsenas wants to merge 1 commit intoakkadotnet:devfrom
MattKotsenas wants to merge 1 commit intoakkadotnet:devfrom
Conversation
…ng Oldest When transitioning from Oldest state, the lease release in GoTo().Using() used ContinueWith(r => new ReleaseLeaseResult(r.Result)) which accesses r.Result unconditionally. If the release task faults, r.Result throws AggregateException, which PipeTo delivers as Status.Failure - an unhandled message that gets silently dropped. The operator gets no error log about the failed lease release. Fix: align with the existing fault-handling pattern in OnTransition(from, to) by checking IsCanceled/IsFaulted first and producing a ReleaseLeaseFailure message, which the FSM already handles with a proper error log. Also add SetNextReleaseResult to TestLease (mirroring the existing SetNextAcquireResult) to enable testing lease release failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When transitioning from Oldest state, the lease release in GoTo().Using() used ContinueWith(r => new ReleaseLeaseResult(r.Result)) which accesses r.Result unconditionally. If the release task faults, r.Result throws AggregateException.
I had to consult Copilot about the user impact of this issue. It says:
However, I'm still new at Cluster, so I'm not sure if that's correct, though the task handling does appear to be a bug. As a result, I aligned with the existing fault-handling pattern in OnTransition(from, to) by checking IsCanceled/IsFaulted first and producing a ReleaseLeaseFailure message, which the FSM already handles with a proper error log.
Also add SetNextReleaseResult to TestLease (mirroring the existing SetNextAcquireResult) to enable testing lease release failures.
Checklist