Skip to content

Implement nullable for Akka.Streams.Implementation.ChannelSources - #7799

Open
Arkatufus wants to merge 3 commits into
akkadotnet:devfrom
Arkatufus:nullable/convert-Akka.Streams.Implementation.ChannelSources
Open

Arkatufus wants to merge 3 commits into
akkadotnet:devfrom
Arkatufus:nullable/convert-Akka.Streams.Implementation.ChannelSources

Merge branch 'dev' into nullable/convert-Akka.Streams.Implementation.…

2f7970e
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR Validation failed Sep 4, 2025 in 22m 50s

Build #2025.9.4.16 had test failures

Details

Tests

  • Failed: 5 (0.06%)
  • Passed: 7,305 (82.25%)
  • Other: 1,571 (17.69%)
  • Total: 8,881

Annotations

Check failure on line 762 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR Validation

Build log #L762

Cmd.exe exited with code '-1'.

Check failure on line 818 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR Validation

Build log #L818

Bash exited with code '255'.

Check failure on line 14 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR Validation

Build log #L14

ECHO is off.

Check failure on line 14 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR Validation

Build log #L14

ECHO is off.

Check failure on line 1 in Akka.Streams.Tests.Dsl.HubSpec.BroadcastHub_must_handle_cancelled_Sink

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR Validation

Akka.Streams.Tests.Dsl.HubSpec.BroadcastHub_must_handle_cancelled_Sink

Failed: Timeout 00:00:03 while waiting for a message of type Akka.Streams.TestKit.TestSubscriber+OnNext`1[System.Int32] 
Raw output
   at Akka.TestKit.Xunit2.XunitAssertions.Fail(String format, Object[] args) in /home/vsts/work/1/s/src/contrib/testkits/Akka.TestKit.Xunit2/XunitAssertions.cs:line 27
   at Akka.TestKit.TestKitBase.InternalExpectMsgEnvelopeAsync[T](Nullable`1 timeout, Action`2 assert, String hint, CancellationToken cancellationToken, Boolean shouldLog) in /home/vsts/work/1/s/src/core/Akka.TestKit/TestKitBase_Expect.cs:line 436
   at Akka.TestKit.TestKitBase.InternalExpectMsgEnvelopeAsync[T](Nullable`1 timeout, Action`1 msgAssert, Action`1 senderAssert, String hint, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/core/Akka.TestKit/TestKitBase_Expect.cs:line 411
   at Akka.TestKit.TestKitBase.InternalExpectMsgAsync[T](Nullable`1 timeout, Action`1 msgAssert, Action`1 senderAssert, String hint, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/core/Akka.TestKit/TestKitBase_Expect.cs:line 379
   at Akka.Streams.TestKit.TestSubscriber.ManualProbe`1.ExpectNextTask(TestProbe probe, T element, Nullable`1 timeout, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/core/Akka.Streams.TestKit/TestSubscriber_Shared.cs:line 36
   at Akka.Streams.TestKit.TestSubscriber.ManualProbe`1.ExpectNextAsync(T element, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/core/Akka.Streams.TestKit/TestSubscriber.cs:line 192
   at Akka.Streams.Tests.Dsl.HubSpec.<BroadcastHub_must_handle_cancelled_Sink>b__29_0() in /home/vsts/work/1/s/src/core/Akka.Streams.Tests/Dsl/HubSpec.cs:line 635
   at Akka.Streams.TestKit.Utils.<>c__DisplayClass5_0.<<AssertAllStagesStoppedAsync>b__0>d.MoveNext() in /home/vsts/work/1/s/src/core/Akka.Streams.TestKit/Utils.cs:line 57
--- End of stack trace from previous location ---
   at Akka.Streams.TestKit.Utils.AssertAllStagesStoppedAsync[T](TestKitBase spec, Func`1 block, IMaterializer materializer, Nullable`1 timeout, CancellationToken cancellationToken)
   at Akka.Streams.TestKit.Utils.AssertAllStagesStoppedAsync(TestKitBase spec, Func`1 block, IMaterializer materializer, Nullable`1 timeout, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/core/Akka.Streams.TestKit/Utils.cs:line 55
   at Akka.Streams.Tests.Dsl.HubSpec.BroadcastHub_must_handle_cancelled_Sink() in /home/vsts/work/1/s/src/core/Akka.Streams.Tests/Dsl/HubSpec.cs:line 621
--- End of stack trace from previous location ---

Check failure on line 1 in Akka.Streams.Tests.Implementation.TimeoutsSpec.InitialTimeout_must_fail_if_no_initial_element_passes_until_timeout

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR Validation

Akka.Streams.Tests.Implementation.TimeoutsSpec.InitialTimeout_must_fail_if_no_initial_element_passes_until_timeout

Failed: Expected no messages during 00:00:00.5000000, instead we received <TestSubscriber.OnError(The first element has not yet passed through in 00:00:01.)> from [akka://TimeoutsSpec-565/user/StreamSupervisor-945/Flow-0-0-initial#147562207] after 00:00:01.0668813
Raw output
   at Akka.TestKit.Xunit2.XunitAssertions.Fail(String format, Object[] args) in /home/vsts/work/1/s/src/contrib/testkits/Akka.TestKit.Xunit2/XunitAssertions.cs:line 27
   at Akka.TestKit.TestKitBase.InternalExpectNoMsgAsync(TimeSpan duration, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/core/Akka.TestKit/TestKitBase_Expect.cs:line 515
   at Akka.Streams.TestKit.TestSubscriber.ManualProbe`1.ExpectNoMsgAsync(TimeSpan remaining, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/core/Akka.Streams.TestKit/TestSubscriber.cs:line 237
   at Akka.Streams.Tests.Implementation.TimeoutsSpec.<InitialTimeout_must_fail_if_no_initial_element_passes_until_timeout>b__6_0() in /home/vsts/work/1/s/src/core/Akka.Streams.Tests/Implementation/TimeoutsSpec.cs:line 74
   at Akka.Streams.TestKit.Utils.<>c__DisplayClass5_0.<<AssertAllStagesStoppedAsync>b__0>d.MoveNext() in /home/vsts/work/1/s/src/core/Akka.Streams.TestKit/Utils.cs:line 57
--- End of stack trace from previous location ---
   at Akka.Streams.TestKit.Utils.AssertAllStagesStoppedAsync[T](TestKitBase spec, Func`1 block, IMaterializer materializer, Nullable`1 timeout, CancellationToken cancellationToken)
   at Akka.Streams.TestKit.Utils.AssertAllStagesStoppedAsync(TestKitBase spec, Func`1 block, IMaterializer materializer, Nullable`1 timeout, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/core/Akka.Streams.TestKit/Utils.cs:line 55
   at Akka.Streams.Tests.Implementation.TimeoutsSpec.InitialTimeout_must_fail_if_no_initial_element_passes_until_timeout() in /home/vsts/work/1/s/src/core/Akka.Streams.Tests/Implementation/TimeoutsSpec.cs:line 66
--- End of stack trace from previous location ---

Check failure on line 1 in Akka.Streams.Tests.Implementation.ChannelSourceSpec.ChannelSource_must_complete_after_channel_fails

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR Validation

Akka.Streams.Tests.Implementation.ChannelSourceSpec.ChannelSource_must_complete_after_channel_fails

Expected object to be System.Exception with message "BOOM!"
, but found <null>.
Raw output
   at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
   at FluentAssertions.Primitives.ObjectAssertions.Be(Object expected, String because, Object[] becauseArgs)
   at Akka.Streams.Tests.Implementation.ChannelSourceSpec.ChannelSource_must_complete_after_channel_fails() in D:\a\1\s\src\core\Akka.Streams.Tests\Implementation\ChannelSourceSpec.cs:line 65

Check failure on line 1 in Akka.Streams.Tests.Implementation.ChannelSourceFromReaderRegressionSpecs.FromReader: failure completion should fail the stream with the same exception

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR Validation

Akka.Streams.Tests.Implementation.ChannelSourceFromReaderRegressionSpecs.FromReader: failure completion should fail the stream with the same exception

Assert.Throws() Failure: Exception type was not an exact match
Expected: typeof(System.InvalidOperationException)
Actual:   typeof(System.AggregateException)
---- System.AggregateException : One or more errors occurred.
-------- System.InvalidOperationException : boom
Raw output
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Akka.Streams.Tests.Implementation.ChannelSourceFromReaderRegressionSpecs.<FromReader_should_propagate_failure_instead_of_throwing_NRE>d__4.MoveNext() in D:\a\1\s\src\core\Akka.Streams.Tests\Implementation\ChannelSourceFromReaderRegressionSpecs.cs:line 98
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
----- Inner Stack Trace -----
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Akka.Streams.Tests.Implementation.TaskTimeoutExtensions.<Within>d__0`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Akka.Streams.Tests.Implementation.ChannelSourceFromReaderRegressionSpecs.<>c__DisplayClass4_0.<<FromReader_should_propagate_failure_instead_of_throwing_NRE>b__0>d.MoveNext() in D:\a\1\s\src\core\Akka.Streams.Tests\Implementation\ChannelSourceFromReaderRegressionSpecs.cs:line 100
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
----- Inner Stack Trace -----