[POC] Proof of concept TypeLoader, replacement for Type.GetType()#7508
Open
Arkatufus wants to merge 4 commits intoakkadotnet:devfrom
Open
[POC] Proof of concept TypeLoader, replacement for Type.GetType()#7508Arkatufus wants to merge 4 commits intoakkadotnet:devfrom
TypeLoader, replacement for Type.GetType()#7508Arkatufus wants to merge 4 commits intoakkadotnet:devfrom
Conversation
Aaronontheweb
requested changes
Feb 18, 2025
Member
Aaronontheweb
left a comment
There was a problem hiding this comment.
I'd prefer something simpler and less generic for this purpose.
internal sealed class KnownTypes {
// ideally, should not need to be concurrent - should all happen at ActorSystem launch
private readonly Dictionary<string, Func<Mailbox>> typesOfMailboxes;
public Func<... args for mailbox, Mailbox> GetMailbox (string typeName) {
}
}We're not going to support type lookup for arbitrary stuff - so no need for a generic abstraction here. It's my preference to make this all as strongly typed, fewest-moving-parts as possible.
…net into feature/AOT-type-loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeLoaderString to Type MapType.GetType()does.nullwhen lookup failed, just likeType.GetType()does.Note that we discard version, culture, and public key metadata. Should we also match these?