Fix DeferAsync causing CircuitBreaker to open during Persist#457
Open
Arkatufus wants to merge 1 commit intoakkadotnet:devfrom
Open
Fix DeferAsync causing CircuitBreaker to open during Persist#457Arkatufus wants to merge 1 commit intoakkadotnet:devfrom
Arkatufus wants to merge 1 commit intoakkadotnet:devfrom
Conversation
(cherry picked from commit c4c83ab)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455
The bug is here. When messages is empty, .ContinueWhenAll() throws because it requires at least one task, this causes circuit breaker to fail. If this happens multiple times, this will cause the circuit breaker to open and blocks all further persist calls.
Changes
Add empty message guard. Just return immediately if there are no messages to persist.