rewrite in typescript and shared / distributed locking#39
Open
simllll wants to merge 6 commits intoaishek:masterfrom
Open
rewrite in typescript and shared / distributed locking#39simllll wants to merge 6 commits intoaishek:masterfrom
simllll wants to merge 6 commits intoaishek:masterfrom
Conversation
Owner
|
Oh, thank you very much! I need some time to review the changes |
Where you able to review the changes @aishek ? I'm currently using this fork to work with Redis but tbh if it were merged to the main project would make it much easier to work with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @aishek , thanks for your awesome work, this Pr is not intended for merging as it contains several changes which are not relevant, but it cointains two things that might be of interest for you:
1.) it is a rewrite in typescript
2.) it changes the rate liminting approach to the one of https://github.com/nfriedly/express-slow-down and also allows to plug in the same stores that express-slow-down and express-rate-limit have already, this furthermore allows to use a "reids" or "memcached" store instead of the memory one, which allows to share locks between different processes/instances.
Feel free to cherry pick commits from my fork and bring them back in to the main library :-)!
npm: https://www.npmjs.com/package/@hokify/axios-rate-limit
source. https://github.com/hokify/axios-rate-limit
Thanks again