Open
Conversation
5 tasks
|
@kimocoder could you take a look at this one when you've the spare cycles please? |
Makefile
Outdated
| EXTRA_CFLAGS += -I$(src)/include -I$(srctree)/$(src)/include | ||
| EXTRA_CFLAGS += -I$(src)/hal/phydm -I$(srctree)/$(src)/hal/phydm | ||
| EXTRA_LDFLAGS += --strip-all -O3 | ||
| ccflags-y += $(USER_ccflags-y) -fno-pie |
There was a problem hiding this comment.
This must remain USER_EXTRA_CFLAGS
giuliobenetti
suggested changes
Jul 1, 2025
giuliobenetti
left a comment
giuliobenetti
left a comment
There was a problem hiding this comment.
Hello @domin144,
except the wrong substitution this patch looks good to me.
Only maybe my commit log could be used to give more informations, check here:
Benetti-Engineering/rtl8188eu@702a90b
I'm going to use this patch once cleaned up in Buildroot where I maintain many WiFi drivers and all patches for Linux 6.15 look the same.
|
Ah, and of course I've build tested this patch as well with that change on Buildroot. |
Commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8fa7292fee5c5240402371ea89ab285ec856c916 drops del_timer_sync() in favor of timer_delete_sync() so let's use the new function when Linux version is 6.15.0 or later. Let's also change Makefile EXTRA_CFLAGS variable to ccflags-y that is the standard variable for CFLAGS.
domin144
force-pushed
the
v5.6.4.2_fix_6.15
branch
from
fd80508 to
6e736a3
Compare
Author
|
Hello @giuliobenetti . |
|
@domin144 LGTM now |
|
@kimocoder kindly ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.