ci(connector-rollout): support cancel action in finalize_rollout#82247
Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Draft
ci(connector-rollout): support cancel action in finalize_rollout#82247Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Conversation
…llout Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
cancelaction tofinalize_rollout.ymlso a canceled connector rollout aborts its active progressive-rollout marker in the registry.Today the workflow only handles
promote/rollback. When a rollout is canceled, the platform never dispatches this workflow, so the connector'sprogressive-rollout.ymlmarker in GCS stays active and the RC keeps being served asrelease_candidate. The platform's definitions refresh then re-creates the rollout on every cycle (aCANCELEDprior rollout does not block re-creation), producing a cancel → re-create loop.Paired with airbytehq/airbyte-platform-internal#19189, which dispatches this workflow with
action=cancelwhen a rollout is canceled. This workflow PR should land first so thecancelinput is accepted before the worker starts sending it.How
cancelto theactionchoice input and to theresolve-varsaction validation.finalize-marker --outcome aborted) forcancelas well asrollback— same registry effect: the marker is retired and the registry recompiled so the RC stops being served.cancelnever setsneeds_pr, so no version-bump/changelog PR is created (that path is promote-only).#connector-publish-updates).Review guide
.github/workflows/finalize_rollout.ymlUser Impact
Canceling a connector rollout now cleanly retires the RC from the registry instead of leaving it active and triggering endless rollout re-creation. No impact on promote/rollback behavior.
Can this PR be safely reverted and rolled back?
Link to Devin session: https://app.devin.ai/sessions/2554c9bc3d90413293f779047a7d7696
Requested by: Aaron ("AJ") Steers (@aaronsteers)