feat(source-asana): migrate to manifest-only with declarative OAuth by lazebnyi · Pull Request #75638 · airbytehq/airbyte

Serhii Lazebnyi (lazebnyi) · 2026-03-30T23:18:35Z

What

Migrates source-asana from a Python YamlDeclarativeSource connector to a manifest-only connector, adds oauth_connector_input_specification for declarative OAuth support, and adds a declarative config migration to replace the deleted Python config_migration.py.

Related: https://github.com/airbytehq/airbyte-internal-issues/issues/16023

How

Manifest-only migration: Removed source_asana/ Python package (source.py, run.py, config_migration.py, __init__.py). Switched base image from python-connector-base to source-declarative-manifest:7.15.0. Updated metadata.yaml tag to language:manifest-only.
Declarative OAuth: Added oauth_connector_input_specification to manifest.yaml with Asana consent/token URLs, authorization_code grant type, and refresh_token extraction.
Config migration: Added config_normalization_rules with ConfigMigration to handle the old {"access_token": "xxx"} format → {"credentials": {"option_title": "PAT Credentials", "personal_access_token": "xxx"}}.
components.py updates: Moved to connector root, replaced pkgutil.get_data("source_asana", ...) with a pathlib.Path-based dual-path strategy, removed broad try/except Exception in favor of guard statements, added defensive .get("properties", {}).

Version bump: 1.5.1 → 1.5.2

Updates since last revision

Fixed _get_stream_schema in components.py which went through several iterations:

Initial state: Used open("/source_declarative_manifest/manifest.yaml") with broad try/except Exception: return {} — violated Python coding standards.
First fix attempt: Used importlib.resources.files("source_declarative_manifest") — failed in CI with ModuleNotFoundError (module doesn't exist outside Docker).
Second fix attempt: Used Path(__file__).parent / "manifest.yaml" as fallback — failed in Docker runtime with NameError because manifest-only connectors load components.py via exec() where __file__ is undefined.
Final fix: Uses globals().get("__file__") guard to safely handle all three environments:
- Docker runtime: /source_declarative_manifest/manifest.yaml exists → used directly
- CI with module import: __file__ is defined → falls back to local path
- CI with exec loading: __file__ is undefined → returns {} gracefully (same behavior as the old try/except)

Review guide

manifest.yaml — oauth_connector_input_specification (lines ~2666-2678) and config_normalization_rules (lines ~2704-2732)
components.py — _get_stream_schema dual-path manifest loading with globals().get("__file__") guard
metadata.yaml — base image and tag changes

Items for reviewer attention

globals().get("__file__") pattern: This is unconventional but necessary because manifest-only Docker images load components.py via exec() where __file__ is not defined. When neither path resolves, opt_fields will be empty (same graceful degradation as the original try/except Exception). Please verify this is acceptable.
Config migration conditions: The Jinja conditions (config.get('access_token') and not config.get('credentials')) differ slightly from the old Python migration, which also checked personal_access_token not in config. Verify against real legacy configs.
get_request_params signature: The override in AsanaHttpRequester uses positional args while the parent HttpRequester now uses keyword-only args (*). This works at runtime but is a signature mismatch worth noting.
CI test failure: The test_basic_read failure is a 401 Unauthorized from expired Asana OAuth credentials in GCP Secret Manager — not caused by this PR. All required checks pass.

User Impact

Users authenticating via OAuth will now use the declarative OAuth flow instead of the platform-hardcoded AsanaOAuthFlow.
Users with legacy configs (access_token at root) will be automatically migrated.
No breaking changes for existing PAT or OAuth users.

Can this PR be safely reverted and rolled back?

YES 💚

Link to Devin session: https://app.devin.ai/sessions/c135ab42decc46f9b389b9d45436a660
Requested by: Serhii Lazebnyi (@lazebnyi)

github-actions · 2026-03-30T23:18:58Z

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

🛠️ Quick Fixes
- /format-fix - Fixes most formatting issues.
- /bump-version - Bumps connector versions, scraping changelog description from the PR title.
❇️ AI Testing and Review (internal link: AI-SDLC Docs):
- /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
- /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
- /ai-review - AI-powered PR review for connector safety and quality gates.
🚀 Connector Releases:
- /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
- /bump-progressive-rollout-version - Bumps connector version with an RC suffix (2.16.10-rc.1) for progressive rollouts (enableProgressiveRollout: true).
  - Example: /bump-progressive-rollout-version changelog="Add new feature for progressive rollout"
☕️ JVM connectors:
- /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
  Example: /update-connector-cdk-version connector=destination-bigquery
🐍 Python connectors:
- /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
- /poe source example lock - Alias for /poe connector source-example lock.
- /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
- /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
⚙️ Admin commands:
- /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
  Example: /force-merge reason="CI is flaky, tests pass locally"

📚 Show Repo Guidance

Helpful Resources

Breaking Changes Guide - Breaking changes, migration guides, and upgrade deadlines
Developing Connectors Locally
Managing Connector Secrets
On-Demand Regression Tests
#connector-ci-issues
#connector-publish-updates
#connector-build-statuses

📝 Edit this welcome message.

github-actions · 2026-03-30T23:21:42Z

`source-asana` Connector Test Results

14 tests 9 ✅ 59s ⏱️
1 suites 4 💤
1 files 1 ❌

For more details on these failures, see this check.

Results for commit e611eba.

♻️ This comment has been updated with latest results.

github-actions · 2026-03-30T23:23:33Z

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-nvnm2rmft-airbyte-growth.vercel.app

Built with commit e611eba.
This pull request is being automatically deployed with vercel-action

Serhii Lazebnyi (lazebnyi) · 2026-03-30T23:50:38Z

/publish-connectors-prerelease

Pre-release Connector Publish Started

Publishing pre-release build for connector source-asana.
PR: #75638

Pre-release versions will be tagged as {version}-preview.e8e82e3
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS ✅

Docker image (pre-release):
airbyte/source-asana:1.5.2-preview.e8e82e3

Docker Hub: https://hub.docker.com/layers/airbyte/source-asana/1.5.2-preview.e8e82e3

Registry JSON:

OSS Registry

Cloud Registry

Aldo Gonzalez (aldogonzalez8)

APPROVED

Serhii Lazebnyi (lazebnyi) · 2026-04-03T02:40:10Z

/publish-connectors-prerelease

Pre-release Connector Publish Started

Publishing pre-release build for connector source-asana.
PR: #75638

Pre-release versions will be tagged as {version}-preview.52555ce
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS ✅

Docker image (pre-release):
airbyte/source-asana:1.5.2-preview.52555ce

Docker Hub: https://hub.docker.com/layers/airbyte/source-asana/1.5.2-preview.52555ce

Registry JSON:

OSS Registry

Cloud Registry

…e OAuth support

Serhii Lazebnyi (lazebnyi) · 2026-04-03T03:52:45Z

/publish-connectors-prerelease

Pre-release Connector Publish Started

Publishing pre-release build for connector source-asana.
PR: #75638

Pre-release versions will be tagged as {version}-preview.0d5de42
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS ✅

Docker image (pre-release):
airbyte/source-asana:1.5.2-preview.0d5de42

Docker Hub: https://hub.docker.com/layers/airbyte/source-asana/1.5.2-preview.0d5de42

Registry JSON:

OSS Registry

Cloud Registry

…backward compatibility Co-Authored-By: gl_serhii.lazebnyi <serglazebny@gmail.com>

Serhii Lazebnyi (lazebnyi) · 2026-04-03T10:24:17Z

/publish-connectors-prerelease

Pre-release Connector Publish Started

Publishing pre-release build for connector source-asana.
PR: #75638

Pre-release versions will be tagged as {version}-preview.608e48f
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS ✅

Docker image (pre-release):
airbyte/source-asana:1.5.2-preview.608e48f

Docker Hub: https://hub.docker.com/layers/airbyte/source-asana/1.5.2-preview.608e48f

Registry JSON:

OSS Registry

Cloud Registry

…t in components.py Replace hard-coded open() with try/except Exception pattern with importlib.resources.files() for loading manifest.yaml. This follows coding standards (no broad exception catching) and uses the modern replacement for pkgutil.get_data. Co-Authored-By: gl_serhii.lazebnyi <serglazebny@gmail.com>

…t loading Replace importlib.resources.files() with pathlib.Path since source_declarative_manifest module doesn't exist in CI test environment. Falls back to local manifest.yaml path when Docker path is unavailable. Co-Authored-By: gl_serhii.lazebnyi <serglazebny@gmail.com>

…y runtime Co-Authored-By: gl_serhii.lazebnyi <serglazebny@gmail.com>

Octavia Squidington III (octavia-squidington-iii) added the connectors/source/asana label Mar 30, 2026

Serhii Lazebnyi (lazebnyi) marked this pull request as ready for review March 30, 2026 23:41

Serhii Lazebnyi (lazebnyi) requested a review from Aldo Gonzalez (aldogonzalez8) March 31, 2026 00:21

Aldo Gonzalez (aldogonzalez8) approved these changes Mar 31, 2026

View reviewed changes

Serhii Lazebnyi (lazebnyi) force-pushed the slazebnyi/source-asana-declarative-oauth branch from 07b2316 to 998dcea Compare April 3, 2026 00:31

fix(source-asana): migrate to manifest-only connector with declarativ…

0d5de42

…e OAuth support

Serhii Lazebnyi (lazebnyi) force-pushed the slazebnyi/source-asana-declarative-oauth branch from 527b548 to 0d5de42 Compare April 3, 2026 03:51

Serhii Lazebnyi (lazebnyi) and others added 2 commits April 3, 2026 05:09

docs(source-asana): add changelog entry for version 1.5.2

875c761

fix(source-asana): add declarative config migration for access_token …

608e48f

…backward compatibility Co-Authored-By: gl_serhii.lazebnyi <serglazebny@gmail.com>

devin-ai-integration bot changed the title ~~feat(source-asana): add oauth_connector_input_specification for declarative OAuth~~ feat(source-asana): migrate to manifest-only with declarative OAuth Apr 3, 2026

devin-ai-integration bot and others added 2 commits April 3, 2026 11:10

fix(source-asana): guard against __file__ not defined in manifest-onl…

e611eba

…y runtime Co-Authored-By: gl_serhii.lazebnyi <serglazebny@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(source-asana): migrate to manifest-only with declarative OAuth#75638

feat(source-asana): migrate to manifest-only with declarative OAuth#75638
Serhii Lazebnyi (lazebnyi) wants to merge 6 commits intomasterfrom
slazebnyi/source-asana-declarative-oauth

Serhii Lazebnyi (lazebnyi) commented Mar 30, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

github-actions bot commented Mar 30, 2026

PR Slash Commands

Helpful Resources

Uh oh!

github-actions bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

Serhii Lazebnyi (lazebnyi) commented Mar 30, 2026 •

edited by github-actions bot

Loading

Uh oh!

Aldo Gonzalez (aldogonzalez8) left a comment

Uh oh!

Serhii Lazebnyi (lazebnyi) commented Apr 3, 2026 •

edited by github-actions bot

Loading

Uh oh!

Serhii Lazebnyi (lazebnyi) commented Apr 3, 2026 •

edited by github-actions bot

Loading

Uh oh!

Serhii Lazebnyi (lazebnyi) commented Apr 3, 2026 •

edited by github-actions bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Serhii Lazebnyi (lazebnyi) commented Mar 30, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Updates since last revision

Review guide

Items for reviewer attention

User Impact

Can this PR be safely reverted and rolled back?

Uh oh!

github-actions bot commented Mar 30, 2026

👋 Greetings, Airbyte Team Member!

PR Slash Commands

Helpful Resources

Uh oh!

github-actions bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

source-asana Connector Test Results

Uh oh!

github-actions bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Serhii Lazebnyi (lazebnyi) commented Mar 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aldo Gonzalez (aldogonzalez8) left a comment

Choose a reason for hiding this comment

Uh oh!

Serhii Lazebnyi (lazebnyi) commented Apr 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Serhii Lazebnyi (lazebnyi) commented Apr 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Serhii Lazebnyi (lazebnyi) commented Apr 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Serhii Lazebnyi (lazebnyi) commented Mar 30, 2026 •

edited by devin-ai-integration bot

Loading

github-actions bot commented Mar 30, 2026 •

edited

Loading

`source-asana` Connector Test Results

github-actions bot commented Mar 30, 2026 •

edited

Loading

Serhii Lazebnyi (lazebnyi) commented Mar 30, 2026 •

edited by github-actions bot

Loading

Serhii Lazebnyi (lazebnyi) commented Apr 3, 2026 •

edited by github-actions bot

Loading

Serhii Lazebnyi (lazebnyi) commented Apr 3, 2026 •

edited by github-actions bot

Loading

Serhii Lazebnyi (lazebnyi) commented Apr 3, 2026 •

edited by github-actions bot

Loading