Reject HTTP/1.1 requests without Host header#12264
Open
Cycloctane wants to merge 6 commits intoaio-libs:masterfrom
Open
Reject HTTP/1.1 requests without Host header#12264Cycloctane wants to merge 6 commits intoaio-libs:masterfrom
Cycloctane wants to merge 6 commits intoaio-libs:masterfrom
Conversation
add host header to request test payloads
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12264 +/- ##
=======================================
Coverage 99.10% 99.11%
=======================================
Files 130 130
Lines 45432 45442 +10
Branches 2400 2401 +1
=======================================
+ Hits 45025 45038 +13
+ Misses 276 273 -3
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
BadHttpMessagewhen a HTTP/1.1 request does not set host headerAre there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Fixes #10600
Checklist
CONTRIBUTORS.txtCHANGES/folder