Open
Conversation
Contributor
|
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you accept our Contributor License Agreement before we can merge your contribution. You can accept the CLA by just copying the sentence below and posting it as a Pull Request Comment. I have read the CLA Document and I hereby accept the CLA 1 out of 2 committers have signed the CLA. |
Author
|
I have read the CLA Document and I hereby accept the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
nscfis not provided as an input to aWannier90WorkChainkind.symbolwith ofkind.nameinWannier90BaseWorkChain(required when atoms have tags)