Skip to content

Two minor bugfixes to the workflow#78

Open
elinscott wants to merge 4 commits intoaiidateam:mainfrom
elinscott:nscf_parent
Open

Two minor bugfixes to the workflow#78
elinscott wants to merge 4 commits intoaiidateam:mainfrom
elinscott:nscf_parent

Conversation

@elinscott
Copy link

This PR fixes two issues:

  • proper catching of the case where nscf is not provided as an input to a Wannier90WorkChain
  • replaces uses of kind.symbol with of kind.name in Wannier90BaseWorkChain (required when atoms have tags)

@aiida-cla-bot
Copy link
Contributor

aiida-cla-bot bot commented Oct 9, 2025

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you accept our Contributor License Agreement before we can merge your contribution. You can accept the CLA by just copying the sentence below and posting it as a Pull Request Comment.


I have read the CLA Document and I hereby accept the CLA


1 out of 2 committers have signed the CLA.
✅ (elinscott)[https://github.com/elinscott]
@mikibonacci
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@elinscott
Copy link
Author

I have read the CLA Document and I hereby accept the CLA

aiida-cla-bot bot added a commit that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants