Skip to content

📚 Add AGENTS.md and CONTRIBUTING.md#7265

Open
GeigerJ2 wants to merge 7 commits intoaiidateam:mainfrom
GeigerJ2:docs/agents_contributing
Open

📚 Add AGENTS.md and CONTRIBUTING.md#7265
GeigerJ2 wants to merge 7 commits intoaiidateam:mainfrom
GeigerJ2:docs/agents_contributing

Conversation

@GeigerJ2
Copy link
Copy Markdown
Collaborator

@GeigerJ2 GeigerJ2 commented Mar 5, 2026

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.86%. Comparing base (15454cd) to head (c74e579).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7265      +/-   ##
==========================================
+ Coverage   79.85%   79.86%   +0.01%     
==========================================
  Files         566      566              
  Lines       43947    43947              
==========================================
+ Hits        35088    35092       +4     
+ Misses       8859     8855       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GeigerJ2 GeigerJ2 force-pushed the docs/agents_contributing branch 2 times, most recently from 485995e to 0bc2c99 Compare March 5, 2026 14:03
AGENTS.md Outdated
## Project overview

AiiDA is a workflow manager for computational science with a strong focus on provenance, performance, and extensibility.
It is written in Python (3.9–3.13) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is written in Python (3.9–3.13) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker.
It is written in Python (3.10–3.13) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker.

## Project overview

AiiDA is a workflow manager for computational science with a strong focus on provenance, performance, and extensibility.
It is written in Python (3.9–3.14) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is written in Python (3.9–3.14) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker.
It is written in Python (3.10–3.14) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker.

All persistent objects inherit from `Entity`.
Nodes form the provenance graph.

```mermaid
Copy link
Copy Markdown
Collaborator Author

@GeigerJ2 GeigerJ2 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mermaid graphs should be machine-readable. I personally find them nice, but we can also drop them. Rendered views:
https://github.com/GeigerJ2/aiida-core/blob/docs/agents_contributing/AGENTS.md#class-hierarchies
Comments, @edan-bainglass, as our ORM expert now?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, we drop the attributes, and show only the inheritance structure?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the thing is that Giovanni and I have plans to restructure the whole ORM 😅 More on this in May

}

StorageBackend <|-- PsqlDosBackend
PsqlDosBackend <|-- SqliteDosStorage
Copy link
Copy Markdown
Collaborator Author

@GeigerJ2 GeigerJ2 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a criminal offense :D

@GeigerJ2 GeigerJ2 force-pushed the docs/agents_contributing branch 2 times, most recently from bbdd806 to ed2c018 Compare March 6, 2026 10:47
@GeigerJ2 GeigerJ2 requested a review from mbercx March 9, 2026 06:48
@GeigerJ2 GeigerJ2 marked this pull request as ready for review March 9, 2026 06:48
Copy link
Copy Markdown
Collaborator

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Just had a very brief look at the CONTRIBUTING.md

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere in this file we should also link to the AI_POLICY I think (once it's merged)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will update :)

@GeigerJ2
Copy link
Copy Markdown
Collaborator Author

TODO: As mentioned by @agoscinski, if this file is loaded automatically into the context of the agent, we should make sure it's not too extensive, or at least ensure that if it is, it does not cause unwanted side effects (e.g., degradation due to context pollution). I'd still need to check and verify this myself. Also, trying out a few LLM-generated PRs, with the file in place.

@GeigerJ2 GeigerJ2 force-pushed the docs/agents_contributing branch from 8297c52 to c74e579 Compare March 31, 2026 13:35
Copy link
Copy Markdown
Collaborator

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that it is not automatically loaded so people can still choose to not use it. In case it does not provide additional benefit, it can be ignored. I think the overall shape looks good but I don't know how well it works in practice. I saw that one can do tests by give it an agent and compare token consumption. I personally don't have such a workflow yet so I suggest to merge it for testing and do QA in the future.

- Fills a non-trivial feature gap not easily resolved otherwise
- Supports all Python versions supported by aiida-core
- Is available on both [PyPI](https://pypi.org/) and [conda-forge](https://conda-forge.org/)
- Uses an MIT-compatible license (MIT, BSD, Apache, LGPLmdash&**not** GPL)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix encoding error

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can add that it should be somewhat actively maintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants