📚 Add AGENTS.md and CONTRIBUTING.md#7265
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7265 +/- ##
==========================================
+ Coverage 79.85% 79.86% +0.01%
==========================================
Files 566 566
Lines 43947 43947
==========================================
+ Hits 35088 35092 +4
+ Misses 8859 8855 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
485995e to
0bc2c99
Compare
AGENTS.md
Outdated
| ## Project overview | ||
|
|
||
| AiiDA is a workflow manager for computational science with a strong focus on provenance, performance, and extensibility. | ||
| It is written in Python (3.9–3.13) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker. |
There was a problem hiding this comment.
| It is written in Python (3.9–3.13) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker. | |
| It is written in Python (3.10–3.13) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker. |
| ## Project overview | ||
|
|
||
| AiiDA is a workflow manager for computational science with a strong focus on provenance, performance, and extensibility. | ||
| It is written in Python (3.9–3.14) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker. |
There was a problem hiding this comment.
| It is written in Python (3.9–3.14) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker. | |
| It is written in Python (3.10–3.14) and uses PostgreSQL/SQLite for metadata storage, [`disk-objectstore`](https://github.com/aiidateam/disk-objectstore) for file storage, and RabbitMQ as a message broker. |
| All persistent objects inherit from `Entity`. | ||
| Nodes form the provenance graph. | ||
|
|
||
| ```mermaid |
There was a problem hiding this comment.
Mermaid graphs should be machine-readable. I personally find them nice, but we can also drop them. Rendered views:
https://github.com/GeigerJ2/aiida-core/blob/docs/agents_contributing/AGENTS.md#class-hierarchies
Comments, @edan-bainglass, as our ORM expert now?
There was a problem hiding this comment.
Possibly, we drop the attributes, and show only the inheritance structure?
There was a problem hiding this comment.
Yeah, the thing is that Giovanni and I have plans to restructure the whole ORM 😅 More on this in May
| } | ||
|
|
||
| StorageBackend <|-- PsqlDosBackend | ||
| PsqlDosBackend <|-- SqliteDosStorage |
There was a problem hiding this comment.
This should be a criminal offense :D
bbdd806 to
ed2c018
Compare
danielhollas
left a comment
There was a problem hiding this comment.
Very cool. Just had a very brief look at the CONTRIBUTING.md
There was a problem hiding this comment.
Somewhere in this file we should also link to the AI_POLICY I think (once it's merged)
There was a problem hiding this comment.
Yes, will update :)
611f6fd to
8297c52
Compare
|
TODO: As mentioned by @agoscinski, if this file is loaded automatically into the context of the agent, we should make sure it's not too extensive, or at least ensure that if it is, it does not cause unwanted side effects (e.g., degradation due to context pollution). I'd still need to check and verify this myself. Also, trying out a few LLM-generated PRs, with the file in place. |
8297c52 to
c74e579
Compare
agoscinski
left a comment
There was a problem hiding this comment.
My understanding is that it is not automatically loaded so people can still choose to not use it. In case it does not provide additional benefit, it can be ignored. I think the overall shape looks good but I don't know how well it works in practice. I saw that one can do tests by give it an agent and compare token consumption. I personally don't have such a workflow yet so I suggest to merge it for testing and do QA in the future.
| - Fills a non-trivial feature gap not easily resolved otherwise | ||
| - Supports all Python versions supported by aiida-core | ||
| - Is available on both [PyPI](https://pypi.org/) and [conda-forge](https://conda-forge.org/) | ||
| - Uses an MIT-compatible license (MIT, BSD, Apache, LGPLmdash&**not** GPL) |
There was a problem hiding this comment.
maybe you can add that it should be somewhat actively maintained
Rendered view here:
https://github.com/GeigerJ2/aiida-core/blob/docs/agents_contributing/AGENTS.md