Add beautifulsoup4 dep (used in guide system)#1465
Merged
edan-bainglass merged 2 commits intoaiidalab:mainfrom Mar 2, 2026
Merged
Add beautifulsoup4 dep (used in guide system)#1465edan-bainglass merged 2 commits intoaiidalab:mainfrom
beautifulsoup4 dep (used in guide system)#1465edan-bainglass merged 2 commits intoaiidalab:mainfrom
Conversation
beautifulsoup dep (used in guide system)beautifulsoup4 dep (used in guide system)
a3d7db2 to
88278a6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
=======================================
Coverage 72.33% 72.33%
=======================================
Files 112 112
Lines 7245 7245
=======================================
Hits 5241 5241
Misses 2004 2004
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should've been added in #763. We haven't had issues because
bs4is a dependency ofnbconvert, so we get it from there. However, #1337 updates the installation scheme, which meansbs4is not available when needed (failing tests there). This PR adds the explicit dependency.Pinging @danielhollas