Add backwards compatibility handler for old input_structure trait#1423
Add backwards compatibility handler for old input_structure trait#1423edan-bainglass merged 1 commit intoaiidalab:mainfrom
input_structure trait#1423Conversation
| # BACKWARDS COMPATIBLE - remove when all plugins are updated! | ||
| warnings.warn( | ||
| ( | ||
| "The `input_structure` dependency is deprecated. " |
There was a problem hiding this comment.
I will include like Plugin developer: ... so the user doesnt get confused with this warning
There was a problem hiding this comment.
When will the user ever see this? These will only show up in tests, or if you switch to edit mode. They won't show in app mode. Note that we do not do "Plugin developer: ..." in any of our warnings. Have users raised this concern?
There was a problem hiding this comment.
ahhh I thought that this will be the warning like the ones that Xing used to put , my bad
There was a problem hiding this comment.
Which ones are those? 😅
There was a problem hiding this comment.
Also, let me know if anything is holding this PR back 🙏
There was a problem hiding this comment.
Nothing (holding this PR), is good , is just that Xing used to put warnings in the app mode, for example some can appear in the Calculation History, is there is an incompatibility or something with the code
There was a problem hiding this comment.
I see. I just tested the vibroscopy plugin (which is incompatible). No warnings shown on install, load, usage, etc. Great if you can approve, so we can merge and proceed 🙏 If for some unforeseen reason, the message shows up in a user interface, we can iterate.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
=======================================
Coverage 72.18% 72.18%
=======================================
Files 108 108
Lines 7259 7263 +4
=======================================
+ Hits 5240 5243 +3
- Misses 2019 2020 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@AndresOrtegaGuerrero note that the failed test is unrelated. This is being handled by #1337, which is now rebased on this due to it failing for plugin incompatibility. |
b4f90a9 to
a506662
Compare
|
@AndresOrtegaGuerrero can I merge this? |
Yes sorry i got busy on other things, thanks! |
This PR adds handling of remaining usage of the old
input_structuretrait, routing to the newstructure_uuidtrait.