Merge v0.9.0-beta-dev into main#293
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75ca2a41b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| requireQuality( | ||
| qodanaCriticalStatus != "unknown-problem-severities-missing", | ||
| "qodana-summary must expose critical-issue status" |
There was a problem hiding this comment.
Allow clean Qodana scans through the gate
When Qodana reports a clean run with zero problems, writeQodanaSummary produces an empty severityCounts map and therefore sets criticalIssuesStatus to unknown-problem-severities-missing while criticalIssues is still 0. This new gate rejects that status, so qualityReportGate/releaseQualityPacket fail specifically for a no-findings Qodana result even though there are no critical issues to block on. Treat the empty-severity/zero-issue case as known-zero rather than missing evidence.
Useful? React with 👍 / 👎.
Merge the beta development branch into main for the 0.10.8 release-candidate staging path.\n\nEvidence before PR:\n- v0.9.0-beta-dev CI passed on run 28756435104\n- Local git diff --check passed on the merge commit\n- No release tag or GitHub Release is created by this PR