Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces asynchronous API methods across the payment gateway client library, converting synchronous operations to async/await patterns. The changes include adding query API functionality with XML deserialization support and updating all test cases to properly await async operations.
Key Changes:
- Converted all public gateway methods from synchronous to asynchronous (
*Asyncnaming convention) - Added new Query API infrastructure with
QueryResponsemodels andMakeQueryRequestmethod - Updated test methods to use
async Taskand properly await async operations - Removed duplicate
OrderIdproperty fromCustomerSaleclass
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| PaymentGateway/GatewayClient.cs | Core async conversion of MakeRequest method and addition of MakeQueryRequest for query API support |
| PaymentGateway/Payment.cs | Converted payment operations (Sale, Authorize, Credit, Validate, Offline, Capture) to async |
| PaymentGateway/Recurring.cs | Converted recurring billing operations to async |
| PaymentGateway/Invoices.cs | Converted invoice operations to async |
| PaymentGateway/CustomerVault.cs | Converted customer vault operations to async with ConfigureAwait(false) |
| PaymentGateway/Models/QueryResponse.cs | New file defining XML response models for query API |
| PaymentGateway/Models/CustomerVault.cs | Removed duplicate OrderId property |
| PaymentGatewayClient.Tests/CCPaymentTest.cs | Updated credit card payment tests to async |
| PaymentGatewayClient.Tests/CheckPaymentTest.cs | Updated check payment tests to async |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Co-authored-by: ahwm <20478373+ahwm@users.noreply.github.com>
Add ConfigureAwait(false) to async methods in Payment, Recurring, and Invoices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.