Give the paged organization list its own cache key - #157
Merged
Conversation
Two screens cached different things under one key: the organizations list flattens every page into an array, while the users list and the app dialog each keep a single response. Whichever ran first decided what the other one read, so opening Users and then Organizations mapped over a response object and threw -- and a render that throws takes the console with it, leaving a blank page where the sidebar had been.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Users and then Organizations blanks the console.
Both screens cached under
['organizations', 'list'], but they cache different shapes:OrganizationsListPagepages through and stores a flattened array, whileUsersListPageandRegisterAppDialogeach store a single response object. Whichever loaded first decided what the other read, so the organizations page mapped over a response object:A render that throws takes the whole console down — the layout unmounts and the page goes blank, sidebar and all.
Found from the trace of
console navigation › opens every platform sidebar section, which walks Users then Organizations and so hits the collision every time; that walk is the regression guard.