Refactor Threads, add Chat service, add delivery open question#17
Open
emerson-gray wants to merge 2 commits into
Open
Refactor Threads, add Chat service, add delivery open question#17emerson-gray wants to merge 2 commits into
emerson-gray wants to merge 2 commits into
Conversation
Threads: - Participant-type-agnostic (removed type enum from Participant) - Added AckMessages method (explicit acknowledgment, separate from reading, handles crash recovery) - Removed read_status from Message model - Business logic lives in services on top of Threads Chat service (new): - Built-in web/mobile app chat experience on top of Threads - Thread lifecycle, unread counts, message delivery for own UI Channels: - Channels create and manage their own threads - Own apps (web, mobile) are not channels — served by Chat - Outbound flow uses AckMessages Open questions: - Added Message Delivery Unification (broker vs notifications+pull) - Removed filesystem store migration (resolved) - Removed resolved sub-questions from Threads Data Store Updated: system-overview, control-data-plane, media, README
- Restored ack_status field on Message in threads.md and media.md (AckMessages writes it, ack_status is how consumers read it) - Replaced Chat responsibilities table with proper Interface (CreateChat, GetChats, GetMessages, SendMessage, MarkAsRead)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threads refactored
typeenum from Participant. Threads identifies participants by ID only, same behavior for all.GetMessages. Handles crash recovery: messages remain unacknowledged until consumer confirms processing.read_statusfrom Message model (acknowledgment tracked separately).Chat service (new —
architecture/chat.md)Built-in web/mobile app chat experience on top of Threads:
Channels updated
AckMessagesOpen questions updated
Other updates
system-overview.md— Chat added to diagram and component table; Gateway routes to Chat instead of Threads directlycontrol-data-plane.md— Chat added as data plane servicemedia.md— removedread_statusfrom Message modelREADME.md— Chat added to index