-
Notifications
You must be signed in to change notification settings - Fork 40
feat(evaluators): new api from runners-api #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
namrataghadi-galileo
wants to merge
10
commits into
main
Choose a base branch
from
feature/67157-refactor-api-runner-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
04a55c3
fix(server): declare plain psycopg dependency
abhinav-galileo 5189827
test(server): support included router route assertions
abhinav-galileo 8c7c83d
new api from runners-api
namrataghadi-galileo 3553b26
update psycopy
namrataghadi-galileo f93f39e
do not require version_id
namrataghadi-galileo 3e9e74c
resolving merge conflicts
namrataghadi-galileo 55d69ac
sqlglot error
namrataghadi-galileo adb96fe
remove the sqlglot changes
namrataghadi-galileo b5146fa
Merge branch 'main' into feature/67157-refactor-api-runner-api
namrataghadi-galileo c4401a1
address comment
namrataghadi-galileo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: since
scorer_idis now required, can we confirm the rollout path for any savedgalileo.lunacontrols that only havescorer_labelorscorer_version_id? A short migration/compat note here or in the PR description would make the break explicit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I’ll make this explicit in the PR notes.
Rollout path: this is a breaking config contract for
galileo.luna. Saved Luna controls must includescorer_id;scorer_labelis now display/metadata only, andscorer_version_idis an optional version pin. The enterprise UI already resolves the selected scorer before save and persistsscorer_id.