fix(server): post objective discussion as one message, not one per me…#42
Merged
Merged
Conversation
…mber
The /objectives/:id/discuss endpoint looped broker.push({ to: member })
once per thread member. broker.push mints a new message id per call, so
one post became N distinct messages — and the web client, deduping by
id on the shared obj:<id> thread, rendered it once per connected member
(3 participants → 3 copies).
Switch to a single multi-recipient push via context.recipients — the
same delivery path channel posts use — producing one message id and one
event-log row. Applied the identical fix to publishObjectiveEvent, which
had the same per-member loop and duplicated lifecycle events too.
Signed-off-by: Andrew Jon Przybilla <andrew@przy.email>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mber
The /objectives/:id/discuss endpoint looped broker.push({ to: member })
once per thread member. broker.push mints a new message id per call, so
one post became N distinct messages — and the web client, deduping by
id on the shared obj: thread, rendered it once per connected member
(3 participants → 3 copies).
Switch to a single multi-recipient push via context.recipients — the
same delivery path channel posts use — producing one message id and one
event-log row. Applied the identical fix to publishObjectiveEvent, which
had the same per-member loop and duplicated lifecycle events too.