Fix TTS cleanText bugs causing incomplete speech playback #902
+58
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cleanText() function was using broken regex patterns that resulted in mangled HTML fragments being returned instead of clean text. This caused TTS to only speak the last segment of responses. Changes: - Replace broken regex HTML parsing with DOMParser (browser native) - Properly extract text content while preserving all readable text - Replace <pre> and <code> tags with placeholder before text extraction - Add fallback for edge cases where DOMParser might fail Before: cleanText output was '</pre> distribution in version.</p>' After: cleanText output is 'Linux Distribution...See code attached...version.' Fixes agent0ai#901 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Replace for-loop with while-loop in speakStream() to handle fast streaming Without this, if finished=true arrives while speech is running, remaining chunks are lost forever due to the guard at line 208 rejecting updates. The while-loop continues checking for new chunks until stream finishes. - Fix audio cancellation bug in speakWithBrowser() and speakWithKokoro() Both functions were calling stopAudio() even when waitForPrevious=true, canceling the speech immediately after waiting for it to finish. Now only calls stopAudio() when NOT waiting for previous speech. - Fix replay button to pass HTML instead of plain text The speak button in simple-action-buttons.js was extracting innerText, preventing cleanText() from finding <pre> and <code> tags to replace. Now passes HTML so code blocks are properly replaced with placeholder. Fixes: agent0ai#901 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
doublefx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multiple critical bugs in the TTS system that caused incomplete speech playback and mangled text output.
Fixes #901
Problems Fixed
1. cleanText() Regex Bug (Primary Issue)
The regex pattern was fundamentally broken, matching from any opening tag to any closing tag and destroying content in between.
Before:
After: Replaced with DOMParser for proper HTML parsing
2. Streaming Race Condition
The for-loop would exit after speaking available chunks. If the
finished=trueupdate arrived while speech was running (polling interval: 25ms), it would be ignored and remaining chunks never spoken.Fix: Replaced for-loop with continuous while-loop that checks for new chunks until stream finishes.
3. Audio Cancellation Bug
Both
speakWithBrowser()andspeakWithKokoro()calledstopAudio()even whenwaitForPrevious=true, canceling speech immediately after waiting for it.Fix: Only call
stopAudio()when NOT waiting for previous speech.4. Replay Button Issue
The speak button extracted plain text instead of HTML, preventing
cleanText()from finding<pre>and<code>tags.Fix: Pass HTML to
cleanText()so code blocks are properly replaced with placeholder.Testing
Files Changed
webui/components/chat/speech/speech-store.jscleanText()with DOMParserspeakStream()stopAudio()logic inspeakWithBrowser()andspeakWithKokoro()webui/components/messages/action-buttons/simple-action-buttons.js