Skip to content

fix(grader): apply classified fallback for after_step constraint #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuishou68 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(grader): apply classified fallback for after_step constraint #1339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion skills/skill-comply/scripts/grader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ def _check_temporal_order(
) -> str | None:
"""Check before_step/after_step constraints. Returns failure reason or None."""
if step.detector.after_step is not None:
after_events = resolved.get(step.detector.after_step, [])
after_events = resolved.get(step.detector.after_step)
if after_events is None:
after_events = classified.get(step.detector.after_step, [])
if not after_events:
return f"after_step '{step.detector.after_step}' not yet detected"
Comment on lines 35 to 40
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing regression test for fixed scenario

No test covers the specific case this PR fixes: an after_step that references a step defined later in spec.steps. Without a test, the bug could silently regress. Consider adding a case to tests/test_grader.py where the classification mock returns events for a forward-referenced step (e.g., step B has after_step: step_C while step_C appears after B in the spec) and asserts that grading still succeeds with the correct temporal order.

latest_after = max(e.timestamp for e in after_events)
Expand Down