feat(community): add trading-skills#1309
feat(community): add trading-skills#1309VictorVVedtion wants to merge 1 commit intoaffaan-m:mainfrom
Conversation
…de skills Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a new Community Projects table entry for 'trading-skills' with GitHub link and description highlighting trading legends as Claude Code skills with pre-trade risk management capabilities. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
Greptile SummaryThis PR adds a single row for trading-skills to the Community Projects table in Confidence Score: 5/5Safe to merge — single README documentation change with only a minor prose discrepancy. The only finding is a P2 count discrepancy (8 vs 68) between the PR description and the README text. No code changes, logic issues, or security concerns exist in the changed file. README.md — verify whether the project has 8 or 68 advisors. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR Author submits community project] --> B[Add row to README Community Projects table]
B --> C[Link to trading-skills GitHub repo]
C --> D[68 trading persona skills]
C --> E[Pre-trade risk gate]
C --> F[Tilt detector]
Reviews (1): Last reviewed commit: "feat(community): add trading-skills — 68..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| | Project | Description | | ||
| |---------|-------------| | ||
| | [EVC](https://github.com/SaigonXIII/evc) | Marketing agent workspace — 42 commands for content operators, brand governance, and multi-channel publishing. [Visual overview](https://saigonxiii.github.io/evc). | | ||
| | [trading-skills](https://github.com/VictorVVedtion/trading-skills) | 68 trading legends as Claude Code skills — Warren Buffett reviews your trades, Jim Simons asks if you backtested. Pre-trade risk gate with ghost warnings from SBF, Do Kwon, 3AC. | |
There was a problem hiding this comment.
The PR description says "8 legendary master trading advisors" but the added README line reads "68 trading legends" — these numbers don't match. Please verify the correct count and update either the PR description or the README entry to be consistent.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="README.md">
<violation number="1" location="README.md:1399">
P3: Count discrepancy: the PR description says "8 legendary master trading advisors" but this line claims "68 trading legends." Please verify the correct number and make the README entry consistent with the actual project content.</violation>
<violation number="2" location="README.md:1399">
P2: README adds a high-visibility external repo link without evidence of org vetting, conflicting with the project’s supply-chain safety policy.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| | Project | Description | | ||
| |---------|-------------| | ||
| | [EVC](https://github.com/SaigonXIII/evc) | Marketing agent workspace — 42 commands for content operators, brand governance, and multi-channel publishing. [Visual overview](https://saigonxiii.github.io/evc). | | ||
| | [trading-skills](https://github.com/VictorVVedtion/trading-skills) | 68 trading legends as Claude Code skills — Warren Buffett reviews your trades, Jim Simons asks if you backtested. Pre-trade risk gate with ghost warnings from SBF, Do Kwon, 3AC. | |
There was a problem hiding this comment.
P2: README adds a high-visibility external repo link without evidence of org vetting, conflicting with the project’s supply-chain safety policy.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README.md, line 1399:
<comment>README adds a high-visibility external repo link without evidence of org vetting, conflicting with the project’s supply-chain safety policy.</comment>
<file context>
@@ -1396,6 +1396,7 @@ Projects built on or inspired by Everything Claude Code:
| Project | Description |
|---------|-------------|
| [EVC](https://github.com/SaigonXIII/evc) | Marketing agent workspace — 42 commands for content operators, brand governance, and multi-channel publishing. [Visual overview](https://saigonxiii.github.io/evc). |
+| [trading-skills](https://github.com/VictorVVedtion/trading-skills) | 68 trading legends as Claude Code skills — Warren Buffett reviews your trades, Jim Simons asks if you backtested. Pre-trade risk gate with ghost warnings from SBF, Do Kwon, 3AC. |
Built something with ECC? Open a PR to add it here.
</file context>
| | Project | Description | | ||
| |---------|-------------| | ||
| | [EVC](https://github.com/SaigonXIII/evc) | Marketing agent workspace — 42 commands for content operators, brand governance, and multi-channel publishing. [Visual overview](https://saigonxiii.github.io/evc). | | ||
| | [trading-skills](https://github.com/VictorVVedtion/trading-skills) | 68 trading legends as Claude Code skills — Warren Buffett reviews your trades, Jim Simons asks if you backtested. Pre-trade risk gate with ghost warnings from SBF, Do Kwon, 3AC. | |
There was a problem hiding this comment.
P3: Count discrepancy: the PR description says "8 legendary master trading advisors" but this line claims "68 trading legends." Please verify the correct number and make the README entry consistent with the actual project content.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README.md, line 1399:
<comment>Count discrepancy: the PR description says "8 legendary master trading advisors" but this line claims "68 trading legends." Please verify the correct number and make the README entry consistent with the actual project content.</comment>
<file context>
@@ -1396,6 +1396,7 @@ Projects built on or inspired by Everything Claude Code:
| Project | Description |
|---------|-------------|
| [EVC](https://github.com/SaigonXIII/evc) | Marketing agent workspace — 42 commands for content operators, brand governance, and multi-channel publishing. [Visual overview](https://saigonxiii.github.io/evc). |
+| [trading-skills](https://github.com/VictorVVedtion/trading-skills) | 68 trading legends as Claude Code skills — Warren Buffett reviews your trades, Jim Simons asks if you backtested. Pre-trade risk gate with ghost warnings from SBF, Do Kwon, 3AC. |
Built something with ECC? Open a PR to add it here.
</file context>
1 participant
Summary
Type
Community Skill
Testing
```bash
curl -fsSL https://raw.githubusercontent.com/VictorVVedtion/trading-skills/main/install.sh | bash
```
Then open Claude Code and discuss any trade — installed master advisors activate automatically.
🤖 Generated with Claude Code
Summary by cubic
Add
trading-skillsto the Community Projects list in README. Links to 68 Claude Code trading advisor skills with a pre-trade risk gate and tilt detection.Written for commit 398177a. Summary will update on new commits.
Summary by CodeRabbit