[jenkins-library] Add post job webhook and clean up cicdPipeline code #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhatG
force-pushed
the
webhooks_and_refactoring
branch
30 times, most recently
from
9ceebdf to
fa36f97
Compare
SerhatG
force-pushed
the
webhooks_and_refactoring
branch
21 times, most recently
from
bf8e5e5 to
72e5f06
Compare
fmadjdian
approved these changes
Jan 8, 2026
fmadjdian
left a comment
fmadjdian
left a comment
There was a problem hiding this comment.
Looks good! Feels like a nice chunk of technical debt paid off.
One small thing that crossed my mind when reading the account selection logic, might be worth keeping an eye on edge cases in the future, but nothing blocking right now.
SerhatG
force-pushed
the
webhooks_and_refactoring
branch
from
72e5f06 to
a7a1497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly moving some functions to their respective packages to tidy it up.