test: expand provider matrix to comment threads, feed and search - #2321
Open
aeharding wants to merge 3 commits into
Open
test: expand provider matrix to comment threads, feed and search#2321aeharding wants to merge 3 commits into
aeharding wants to merge 3 commits into
Conversation
Pagination, max_depth/child_count and search are now derived from the seed
store on both fakes, so the specs pinned to lemmyv1 for those reasons move
to e2e/matrix and run on both providers:
- comment-thread: all 5 tests
- feed-interactions: pagination, sort, listing type, mark-read-on-open,
load-failure recovery (post hiding stays — "not sent to the server" can
only be asserted against a concrete v1 route)
- search: posts, communities, empty state (random community stays —
getRandomCommunity is unsupported on piefed)
Two provider divergences get fixture support instead of forked specs:
api.sorts maps a Voyager sort option to the selected mode's canonical value
("new" vs "New"), and INITIAL_COMMENT_DEPTH captures that max_depth counts
from the post on Lemmy but from top-level on PieFed.
Adversarial review findings: - post hiding moves to the matrix. Its old home was justified by asserting no POST /api/v4/post/hide, but threadiverse exposes no hide operation, so that request can never happen and the assertion can never fail. It now compares recorded writes before and after hiding, which is the actual claim and works on any provider. - INITIAL_COMMENT_DEPTH derives from MAX_DEFAULT_COMMENT_DEPTH (+1 on piefed) instead of two magic numbers, so a change to the app constant can't silently desync the fixture. - seedCommentChain ids no longer collide with spec-chosen ones, and the feed page size imports LIMIT rather than restating 50.
aeharding
marked this pull request as ready for review
July 25, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.