Merged
Conversation
Collaborator
Author
|
@adriangb it appears that CI fails since the "Check release process" job needs the Windows/Mac jobs to run, but they only run on pushes to main. Should Windows/Mac jobs run on PR commits, or should the "Check release process" run only on commits to main? |
Owner
|
Probably need a separate check job for PRs. Windows at least is quite a bit slower to run so I'd keep PRs to just Linux. |
adriangb
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration tests to confirm that data is correctly loaded to Postgres. Uses the
postgresql_embeddedcrate to spin up a Postgres instance, avoiding needing to have one already deployed.