Skip to content

fix bug in uix-host port.ts#88

Merged
fe-lix- merged 1 commit intomainfrom
bug-fix
Jul 29, 2025
Merged

fix bug in uix-host port.ts#88
fe-lix- merged 1 commit intomainfrom
bug-fix

Conversation

@AmyJZhao
Copy link
Member

@AmyJZhao AmyJZhao commented Jul 28, 2025

Description

Bug fix for #86 in uix-host package

Related Issue

Motivation and Context

How Has This Been Tested?

In uix-sdk:

npm install
npm run build
cd packages/uix-host
yalc publish

In aem-headless-ui-commons (repo https://github.com/OneAdobe/aem-headless-ui-commons)

update package.json in packages/commons-extensible by adding .yalc to "files"

"files": [
    "README.md",
    "dist/*",
    ".yalc"
  ]

then:

yarn clean-install
cd packages/commons-extensible
yalc add @adobe/uix-host
cd ..
yarn prepack
yalc publish

In aem-headless-ui-admin (repo https://github.com/OneAdobe/aem-headless-ui-admin):

yarn install
yalc add @adobe/uix-host
yalc add @aem-sites/commons-extensible
yarn start

then open instance in local development:
https://experience-stage.adobe.com/?repo=author-p77504-e175976-cmstg.adobeaemcloud.com&env=dev&shell_source=dev&shell_devmode=true&devMode=true#/@aem-sites-engineering/aem/cf/admin/?appId=aem-cf-admin

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AmyJZhao AmyJZhao requested a review from kokoc July 28, 2025 20:53
@fe-lix- fe-lix- merged commit 530e086 into main Jul 29, 2025
2 checks passed
@AmyJZhao
Copy link
Member Author

Fixing the steps in aem-headless-ui-commons:

yarn clean-install
yalc add @adobe/uix-host
cd packages/commons-extensible
yalc add @adobe/uix-host
cd ../..
yarn prepack
cd packages/commons-extensible
yalc publish

AmyJZhao added a commit that referenced this pull request Aug 28, 2025
#88 & #86 (#89)

* url extension provider URL validation

* linting

* fix test

* working url validation

* revert changes to GuestUIFrame and port.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants