SITES-30879: Unlocalized strings in Sites > Page Editor > Search component#3001
Open
alp87488 wants to merge 3 commits intoadobe:mainfrom
Open
SITES-30879: Unlocalized strings in Sites > Page Editor > Search component#3001alp87488 wants to merge 3 commits intoadobe:mainfrom
alp87488 wants to merge 3 commits intoadobe:mainfrom
Conversation
|
|
|
vladbailescu
approved these changes
Feb 26, 2026
vladbailescu
requested changes
Feb 26, 2026
Member
There was a problem hiding this comment.
I think this is a good approach, yet in this form it is causing unit tests failures:
[INFO] Running com.adobe.cq.wcm.core.components.internal.models.v1.SearchImplTest
Error: Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.068 s <<< FAILURE! - in com.adobe.cq.wcm.core.components.internal.models.v1.SearchImplTest
Error: com.adobe.cq.wcm.core.components.internal.models.v1.SearchImplTest.testSearchProperties_noPath Time elapsed: 0.014 s <<< FAILURE!
java.lang.AssertionError:
Unexpected: i18nMessages
at com.adobe.cq.wcm.core.components.internal.models.v1.SearchImplTest.testSearchProperties_noPath(SearchImplTest.java:76)
Error: com.adobe.cq.wcm.core.components.internal.models.v1.SearchImplTest.testSearchProperties Time elapsed: 0.012 s <<< FAILURE!
java.lang.AssertionError:
Unexpected: i18nMessages
at com.adobe.cq.wcm.core.components.internal.models.v1.SearchImplTest.testSearchProperties(SearchImplTest.java:64)
@alp87488, tests for Search v1 and v2 need to updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.corp.adobe.com/browse/SITES-30879
Pass localized messages from model
Fixes #1, Fixes #2