Issue #2989 [DefaultPathProcessor] Implementation-dependent tests in testVanityUrl and testVanityConfig#2991
Open
kabo87777 wants to merge 3 commits intoadobe:mainfrom
Open
Issue #2989 [DefaultPathProcessor] Implementation-dependent tests in testVanityUrl and testVanityConfig#2991kabo87777 wants to merge 3 commits intoadobe:mainfrom
kabo87777 wants to merge 3 commits intoadobe:mainfrom
Conversation
|
santhanbattina
approved these changes
Feb 11, 2026
There was a problem hiding this comment.
Nice improvement here, I like the direction of making these tests less dependent on implementation details.
One small thought: vanity URL tests can get flaky if they rely on implicit ordering or default configs from the test environment. Maybe we can make the setup a bit more explicit so the expected result is fully deterministic (especially if multiple vanity values exist).
Not a blocker at all, just something that might help avoid future CI surprises. Overall this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix ID(Implementation-dependent) tests in DefaultPathProcessorTest
Solution
For testVanityUrl:
Externalizerservice availability before component registrationFor testVanityConfig:
ResourceResolverinstancesCoreComponentTestContextmapping orderVerification
This fix ensures the test suite remains robust and reliable, supporting the overall quality of the AEM Core Components project.